#tde-devs < 2023/06/19 >
[01:04]micheleC has joined
[06:54]denk: micheleC: please review #359
[08:41]micheleC: @denk: I checked. Can you look at the indentation of the "HINTS" part? see line 34 for reference of the indentation
[08:51]denk: 3rd commit, please review
[08:52]denk: btw, I took it from another file from the project because I'm not an expert in cmake
[09:03]micheleC: sure, it's just to have the same format within the same file, so either follow the existing one or update the existing one to the new one. Will check the new commit shortly
[09:08]micheleC: at line 34, HINTS is aligned with PATH_USBIDS and then the various paths are aligned with each other. Latest commits align the paths but it looks better to align HINTS to REBOOT_BINARY (and other binraies too)
[09:25]denk: another commit, check it
[09:28]micheleC: looks good tome
[09:28]micheleC: to me
[09:28]micheleC: @SlavekB: please let us know if you have further comments on it
[09:30]denk: and squash it on merge
[09:31]denk: one more question, is it possible to use ssh keys instead of login+password via https?
[09:32]denk: from time to time git asks me the password, I would like to avoid it using ssh
[09:36]micheleC: yes, you can setup ssh keys. That is what we usually use
[09:36]micheleC: squash and rebase needs to be done before merge
[09:36]micheleC: so you can prepare that already if you want
[09:40]micheleC: for ssh, you have to setup your keys in the profile, then check out the repo using ssh path instead of http
[09:42]denk: ok, found ssh keys tab
[10:04]micheleC: once you use ssh keys, you will also be able to sign commits with your key using -S
[10:05]micheleC: this will show the commit as verified and in green on tgw
[10:58]denk: ssh does not work, I missed something
[10:59]denk: git asked the password
[10:59]denk: I think I will fix it next time
[14:15]micheleC has left (Kopete 0.12.7 : http://trinitydesktop.org)
[18:20]tde-bot has joined
[18:20]tde-bot started logging
[22:55]micheleC has joined

#tde-devs < 2023/06/19 >