#tde-devs < 2024/04/02 > |
|---|
| [08:55] | SlavekB has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org) |
| [09:50] | SlavekB has joined |
| [11:41] | denk: SlavekB: any comments about my PR? |
| [11:41] | denk: https://mirror.git.trinitydesktop.org/gitea/TDE/tde-packaging/pulls/300 |
| [11:41] | tde-bot: Page title: #300 - FreeBSD: basename defined in libgen.h - tde-packaging - TDE Gitea Workspace |
| [12:08] | SlavekB: Denk, comment added. |
| [12:24] | denk: will do it |
| [12:45] | denk: SlavekB: check it please |
| [12:49] | SlavekB: The commit message is now a little confused - the same text is 2×. At the same time, the prefix "FreeBSD:" should be preserved there, because the patch in tde-packaging touches only FreeBSD ports. |
| [12:52] | denk: something fixed |
| [12:52] | denk: check it |
| [12:55] | SlavekB: Partially better. However, I propose to use prefix: "FreeBSD imlib: " instead of "system idependent: ". |
| [12:56] | SlavekB: There it should be clear what the patch is about. The current message is very unclear. |
| [12:56] | denk: fixed, once again please :) |
| [13:00] | SlavekB: Now I have looked into the source file and I am a little confused about the fact that the include <string.h> a few lines higher is with the ifdef HAVE_BASENAME. |
| [13:01] | denk: probably freebsd moved the declaration of the function from one file to another |
| [13:02] | SlavekB: It seems that the include <libgen.h> would probably make sense to place in the same #ifdef. |
| [13:02] | denk: maybe since some version of the system |
| [13:03] | SlavekB: It seems as standard location: |
| [13:03] | SlavekB: https://man7.org/linux/man-pages/man3/basename.3.html |
| [13:03] | tde-bot: Page title: basename(3) - Linux manual page |
| [13:04] | denk: There are two different versions of basename()... |
| [13:04] | SlavekB: Yes, now I see it. |
| [13:05] | denk: I helped GuestXX to build it for freebsd, then I rebuilt it on my home system |
| [13:05] | denk: man gave me the answer abount libgen.h |
| [13:07] | SlavekB: Yes, that's good clarification. It may be advisable to add a test to whether there is a basename in the GNU variant or whether it should be used libgen.h include. |
| [13:08] | denk: I did not see imlib in the source tree to do it |
| [13:10] | SlavekB: Imlib is an external dependence needed for build. We only maintan additional patches, but we do not release new versions. |
| [13:10] | SlavekB: Therefore, we do not maintain separate source code repository for imlib. |
| [13:11] | denk: that is why I added the patch to the ports tree |
| [13:11] | SlavekB: Yes, you chose the right procedure. |
| [13:12] | SlavekB: But it seems that the fix will require to be a little more complex. |
| [13:13] | denk: also I'd like to fix C++ standard which used to build ports |
| [13:13] | denk: by default freebsd uses c++17 |
| [13:14] | denk: but to build ports we need c++11 (the lastest with auto_ptr and other) |
| [13:14] | SlavekB: Maybe there might be: |
| [13:14] | SlavekB: #if HAVE_BASENAME |
| [13:14] | SlavekB: # ifdef _GNU_SOURCE |
| [13:14] | SlavekB: # include <string.h> |
| [13:14] | SlavekB: # else |
| [13:14] | SlavekB: # include <libgen.h> |
| [13:14] | SlavekB: # endif |
| [13:14] | SlavekB: #endif |
| [13:15] | denk: well, I can test it right now |
| [13:17] | SlavekB: ehm, another strange thing. |
| [13:18] | SlavekB: _GNU_SOURCE is defined a few lines above - at begging of file. |
| [13:19] | denk: colors.c:192:12: error: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] |
| [13:19] | denk: 192 | ctmp = basename(file); |
| [13:19] | SlavekB: About C++ standard: The requirement of the standard is designed so that it should only be forced if the current CPP does not have as a default C++11 or later. |
| [13:20] | denk: no, your variant does not work |
| [13:26] | SlavekB: Yes, it is influenced by defining _GNU_SOURCE at the beginning of the file. |
| [13:27] | SlavekB: It seems that we will not avoid adding detection in automake rules. |
| [13:28] | denk: https://github.com/freebsd/freebsd-src/blob/main/include/libgen.h |
| [13:28] | tde-bot: Page title: freebsd-src/include/libgen.h at main · freebsd/freebsd-src · GitHub |
| [13:28] | denk: line 43 |
| [13:32] | denk: I have no good ideas, only #ifdef __FreeBSD__ |
| [13:37] | SlavekB: It will be useful for the patch to be used independently of the system. As I mentioned, it will require an modification of automake detection rules. |
| [13:37] | denk: https://paste.dilos.org/?32a3e0079816ea61#7BFjB269VGnb1YWqbJoNxgYJbCKacq0AqPruScL/4IM= |
| [13:37] | tde-bot: Page title: PrivateBin |
| [18:34] | SlavekB has quit (Quit: TDE Kopete : https://trinitydesktop.org) |
| [22:27] | SlavekB has joined |
| [23:41] | micheleC has joined |
#tde-devs < 2024/04/02 > |
|---|
