#tde-devs < 2024/05/10 > |
[00:59] | micheleC has joined |
[00:59] | micheleC: @ahk online |
[01:08] | akh: Hi |
[01:09] | micheleC: I saw you asking if anyone was online, so just wondering if you had a question |
[01:10] | akh: Yea |
[01:12] | akh: First off, I submitted an xattr patch a while back. Had some personal issues come up and kind of dropped the ball on it. Do you know the status of it? What neeeds to be done on my side to get it included? |
[01:13] | micheleC: did you create a PR on TGW for that? or sent it to the ML? |
[01:14] | akh: Second, I've got a patch that adds read support for WebP to kimgio and to tdeio_thumbnail. Can you give a quick refresher of how I can can submit the patch? |
[01:15] | akh: For xattr: https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/185 |
[01:25] | akh: Am I correct that for a new PR the process is pull, apply changes, push, then (via the website) submit a PR? |
[01:27] | akh: (I have SSH and GPG keys registered) |
[01:28] | micheleC: refresher instructions here: https://wiki.trinitydesktop.org/TDE_Gitea_Workspace#To_contribute_code_changes |
[01:29] | micheleC: yes, pull latest code, make changes, create PR against master |
[01:30] | micheleC: for xattr, we will take a look. as usual, too may things to do and sometimes things get left behind. Thanks for the reminder |
[01:30] | akh: OK, excellent. I'll see about submitting the webp patches |
[01:33] | micheleC: (y) |
[01:33] | akh: As for graphics code, is supporting big- and little-endian systems sufficient? Do mixed-endian systems need to be supported? |
[01:33] | akh: (Do any mixed-endian systems even exist any more?) |
[01:37] | micheleC: I had a quick look at https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/185. You marked it as WIP since it was pending the detection of libattr thorugh cmake |
[01:37] | micheleC: so we didn't do further checks on that |
[01:38] | akh: So for xattr I should just verify that the cmake code is correct? |
[01:38] | micheleC: based on your comment, we need to detect if libattr is avaiable |
[01:38] | micheleC: so you can refer to ConfigureChecks.cmake files from other repos as a guideline on how to do it |
[01:40] | akh: OK, will do. (IIRC my webp code uses similar cmake code) |
[01:41] | micheleC: (y) |
[01:49] | akh: Regarding graphics, do any native TDE applications support editing (not just viewing) images with variable opacity? Part of why my webp patch only has read support is that I have no way to fully test saving. |
[01:50] | micheleC: can't remember out of my head tbh |
[01:50] | micheleC: you will probably have to give it a go and see which apps support that and which one don't |
[01:53] | akh: kpaint doesn't, Though I suppose that for testing purposes just loading an image with variable alpha into e.g. gwenview and then re-saving it from there would suffice. |
[01:55] | akh: Anyway, IMO webp read (and thumbnail) support are what's really important. |
[02:01] | akh: Thnx |
[03:17] | micheleC: (y) |
[06:15] | akh: ping |
[09:23] | micheleC has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org) |
[15:15] | SlavekB has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org) |
[21:33] | SlavekB has joined |
#tde-devs < 2024/05/10 > |