#tde-devs < 2026/01/11 >
[06:22]micheleC has joined
[07:16]micheleC has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org)
[08:21]micheleC has joined
[08:52]denk: https://paste.dilos.org/?12bb4db6f5a7f382#14MqxhfPaiWxKvRQi58Zo2Kz8rmgz6sP1iGpM8sy/Xc=
[08:52]tde-bot: Page title: PrivateBin
[08:53]denk: could you help to fix that shit?
[09:05]micheleC: there is no patch to merge in kerberostray tde-packaging info. Do you have some local patch? in that case you need to see what is causing a conflict
[09:06]denk: no, I did not change anything in that modules
[09:06]denk: it could be a broken git process due to uplink down
[09:07]denk: or something like that
[09:08]denk: maybe reclone the whole repo again?
[09:08]micheleC: give it a go
[09:08]micheleC: just in case
[09:09]denk: home-srv% ./scripts/switch_all_submodules_to_head_and_clean
[09:09]denk: There is not active branch. Exiting...
[09:09]denk: huh
[09:10]SlavekB: You can try running "git checkout master && switch_all_submodules_to_head_and_clean" first in main/applications/misc/kerberostray
[09:10]denk: home-srv% cd main/applications/misc/kerberostray
[09:10]denk: home-srv% git checkout master
[09:10]denk: Already on 'master'
[09:10]denk: Your branch is up to date with 'origin/master'.
[09:10]denk: that is very strange to me
[09:11]denk: there is the same result
[09:11]denk: home-srv% ./scripts/switch_all_submodules_to_head_and_clean
[09:11]denk: There is not active branch. Exiting...
[09:12]denk: do you need to break something? Just call me :)
[09:14]denk: ok, it did something: https://paste.dilos.org/?4410520a4b593dbb#60dFws4PXwJUs7xDM/sU3GXsrvV2ydPn0Wp4CzIbldE=
[09:18]denk: I think I will fix it now, thanks!
[09:55]denk: https://mirror.git.trinitydesktop.org/gitea/TDE/tqt/pulls/261
[09:56]denk: please review
[09:56]tde-bot: Page title: #261 - fix adding a pointer to a char - tqt - TDE Gitea Workspace
[10:02]denk: https://mirror.git.trinitydesktop.org/gitea/TDE/tqt/pulls/262
[10:02]tde-bot: Page title: #262 - fix loop empty body warning - tqt - TDE Gitea Workspace
[10:03]denk: one more cosmetic fix
[12:03]denk: micheleC: check 261 please
[12:06]SlavekB: y
[12:07]SlavekB has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org)
[12:16]denk: https://mirror.git.trinitydesktop.org/gitea/TDE/tqt/pulls/263
[12:16]tde-bot: Page title: #263 - fix casting an integer value to a pointer - tqt - TDE Gitea Workspace
[12:16]denk: another PR for review
[12:22]denk: https://mirror.git.trinitydesktop.org/gitea/TDE/tqt/pulls/264
[12:22]tde-bot: Page title: #264 - fix ambiguous of operations - tqt - TDE Gitea Workspace
[12:22]denk: and more PR for qmake
[12:23]micheleC: @denk: I suggest you make a single PR with all these small fixes, it is easier to review at once rather than one warning at a time, IMO
[12:32]denk: ok, let I do it next time
[12:32]denk: but one PR for one issue
[12:34]denk: https://paste.dilos.org/?716cefcb56816c22#dnVH7jBMDp/4v2IEyXVM8sKrIJ0wCmM0/N7/6yu8gAM=
[12:34]tde-bot: Page title: PrivateBin
[12:34]denk: another issue, but I'm not sure to fix the cpp file
[12:35]denk: yylex is overhead for me
[12:45]denk: micheleC: check 261 once again
[12:46]micheleC: I am lookint at it now. Is the double TQString() needed?
[12:47]micheleC: TQString msg("%1 must be followed immediately by =").arg(*d); does not work?
[12:47]micheleC: I didn't test it
[12:48]denk: by the login - no, it should not work
[12:48]denk: TQString msg("xxx") - create an object
[12:48]denk: msg.arg(xxx) - create another object, but you don't have a reference to it
[12:49]denk: it exists until you leave a block {} or ()
[12:51]micheleC: ah ofcourse, stupid me :facepalm:
[12:52]micheleC: I was convinced arg() was doing inplace replacement
[12:52]micheleC: but instead return a new TQString object
[12:52]micheleC: y bad
[12:52]micheleC: my bad
[12:54]denk: micheleC: https://paste.dilos.org/?061986b1cd3adeb7#ndRc9z0L94tFWHy8v9PJ++Q6eKNhYvH913acyJDesTg=
[12:54]micheleC: now I understand why you put the arg() in the call to qmake_error_msg
[12:56]micheleC: I will merge it
[12:56]micheleC: but if you have multiple small fixed, I suggest you gather them in a single PR. You can can multiple commits in the same PR
[12:56]micheleC: the reason is that everytime we merge a PR, Slavek will need to rebuild the packages for PSB/PTB
[12:57]micheleC: so a single PR "Silence warnings" is probably better
[12:58]denk: every warning could be a big error (depends of the platform)
[12:58]denk: that is why I would not call it just silence
[12:58]denk: sorry
[12:59]denk: I fixed many many SUGBUSes due to port GNU softaware to sparc
[13:00]denk: because somebody hides some warnings
[13:00]micheleC: fixing warning is good and the effort is appreciated.
[13:01]denk: btw, shoud I squash #261?
[13:01]micheleC: but in case of explicit cast we have to be careful. and adding a union to avoid that cast warning on what was an explicit case is not nice
[13:01]micheleC: yes, please squash, as requested.
[13:01]denk: ok, squash trening :)
[13:02]micheleC: you mean you need info on how to squash?
[13:02]SlavekB has joined
[13:04]denk: check #261
[13:07]micheleC: it looks good. one last thing. can you fix up the commit message? we are not really adding a pointer to a char, even if the compiler said so. We are concatenating a char and a string
[13:10]denk: fix the commit and title on the web
[13:19]micheleC: ehm... forgot the sign-off when you fixed the commit...
[13:19]micheleC: apologies for being a bit of a PITA
[13:19]micheleC: :-)
[13:20]denk: what?
[13:20]denk: I used -amend
[13:21]micheleC: commit -s
[13:21]denk: is it possible to fix it?
[13:21]micheleC: it adds "sign-off by" to the commit
[13:22]denk: check the result
[13:22]denk: I did ... something
[13:22]micheleC: now it is ok
[13:22]micheleC: I will merge
[13:23]denk: nice, -1 PR :)
[13:26]denk: micheleC: https://paste.dilos.org/?6c1028fbcdeb5570#S/Xtfo/cqt2LwzBdbVR/ZLwyYqShOU7qZTMEA8+yu+o=
[13:26]denk: building tqmake from the configure
[13:27]denk: there is #262 only twice in the only file
[13:29]micheleC: I remember seeing more than 2 usage like that
[13:30]denk: tell me the file and lines
[13:32]micheleC: I can count at least 8 lines before line 390. There could be 20 or more
[13:32]micheleC: you just need to open the cpp file and search thorugh the various for()
[13:35]denk: why the lines do not produce the warning?
[13:36]micheleC: not sure, but you can see those lines are there....
[13:38]denk: https://stackoverflow.com/questions/37046640/checking-for-empty-for-loops-in-c
[13:38]tde-bot: Page title: templates - Checking for empty for loops in C++ - Stack Overflow
[13:40]denk: https://github.com/llvm/llvm-project/issues/56452
[13:40]tde-bot: Page title: Possible false positive -Wempty-body when indented semicolon after statement · Issue #56452 · llvm/llvm-project · GitHub
[13:44]denk: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62184
[13:44]tde-bot: Page title: Making sure you're not a bot!
[13:46]denk: for (...)
[13:46]denk: ;
[13:46]denk: does not produce the warning
[13:47]denk: just move the semicolon to a new line
[13:50]micheleC: it is good to add { } and a comment after the semicolon , like
[13:50]micheleC: {
[13:50]micheleC: ; // empty body
[13:50]micheleC: }
[13:53]denk: everywhere?
[14:00]denk: fixed as you said
[14:00]denk: also I did squash
[14:00]denk: check it
[14:04]micheleC: let me see
[14:10]micheleC: see comment there. btw when you create a PR please add TDE/Core and TDE/Owners as reviewers please
[14:13]denk: ok, I will try it next time
[14:17]micheleC: (y)
[14:26]denk: #262 updated
[14:33]micheleC: merged
[14:35]micheleC: #263 is just bad practice
[14:35]micheleC: your are still casting, but hiding the cast.
[14:37]micheleC: I am off to bed, I will review further tomorrow if you have more PRs
[14:37]micheleC: well, not quite yet :-)
[14:39]denk: ok, good night
[14:44]micheleC: thanks (y)
[14:44]micheleC has left (Kopete 0.12.7 : http://trinitydesktop.org)
[23:39]SlavekB has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org)

#tde-devs < 2026/01/11 >