tde-devs@chat.jabb.im < 2021/10/21 >
[01:19]michelec2 has joined
[02:25]michelec2 has left
[02:25]michelec2 has joined
[03:26]michelec2 has left
[03:26]michelec2 has joined
[04:49]michelec2: to all, when you have time please help reviewing this PR
https://mirror.git.trinitydesktop.org/gitea/TDE/libr/pulls/7
[04:50]michelec2: ups :-(
[04:50]michelec2: sorry, wrong PR!
[04:56]michelec2: Here is the right PR :-)
https://mirror.git.trinitydesktop.org/gitea/MicheleC/libr-style-test/pulls/1
[04:58]michelec2 has left
[08:41]Slávek has left
[10:01]Slávek has joined
[11:13]blu.256 has left
[13:30]michelec2 has joined
[13:42]michelec2: @Philippe: thanks for reviewing the PR but I don't see any comment in the code :-(
[14:07]blu.256 has joined
[14:08]blu.256 has left
[14:08]blu.256 has joined
[14:21]blu.256: @Michele I can see them in the "Files Changed" tab of the PR
[14:22]michelec2: Hi Philippe, see comment I just posted on the PR
[14:22]blu.256 has left
[14:22]michelec2: maybe you need to complete the review
[14:27]blu.256 has joined
[14:28]blu.256: done, thanks!
[14:28]blu.256 has left
[14:29]michelec2: nice, now I can see them. Thanks for the review. Fixing will take time because it will be a combination of configuration and possibly fixes to upstream uncrustify project
[14:29]blu.256 has joined
[14:29]michelec2: but it is good to start on a real repo, so far I had been doing preparation work only on a test repo
[14:30]michelec2: don't expect immediate answers to the questions, I take them as open points and will work through them step by step
[14:30]blu.256: yes, of course
[14:32]blu.256 has left
[14:32]michelec2: wow.... there is "goto" in the code.... that is probably something we should rework and eliminate :-)
[14:35]michelec2: well, time to sleep for me guys. have a good evening
[14:35]michelec2: talk to you tomorrow
[14:35]michelec2 has left
[14:52]Slávek has left
[14:52]blu.256 has joined
[14:53]blu.256: "goto" is not bad per se; remember switch-case statements are really an extended goto variant ;-)
[14:53]blu.256 has left
[14:54]blu.256 has joined
[14:54]blu.256: would be best to avoid it nonetheless
[14:54]blu.256 has left
[16:55]blu.256 has joined
[16:56]blu.256 has left
[17:40]blu.256 has joined
[17:40]blu.256 has left
[18:40]blu.256 has joined
[22:18]Slávek has joined

tde-devs@chat.jabb.im < 2021/10/21 >