tde-devs@chat.jabb.im < 2022/01/26 >
[10:55]michelec2 has joined
[10:56]michelec2: @Philippe: TDE/tdegraphics#18 see my last comment
[10:56]tde-bot: [TGW][tdegraphics] #18 - Properly declare function argment type
https://mirror.git.trinitydesktop.org/gitea/TDE/tdegraphics/pulls/18
[10:56]michelec2: I think ok to merge as is
[11:06]Slávek: tdegraphics or TDE/tdetoys#18?
[11:06]tde-bot: [TGW][tdetoys] #18 - WIP: KWeather XDG icon names and icon theme support
https://mirror.git.trinitydesktop.org/gitea/TDE/tdetoys/pulls/18
[12:49]blu.256: I just merged it
[12:49]blu.256: but I forgot to squash commits beforehand
[12:50]blu.256: damn I made a mess :/
[12:51]blu.256: sorry for that
[12:55]blu.256: I'd like to hear your opinions on TDE/tdelibs#150 which adds Let's Encrypt certificates
[12:55]tde-bot: [TGW][tdelibs] #150 - KSSL: Add Let's Encrypt certificates support
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/150
[14:45]michelec2: :-$ I almost wanted to mention on PR to squash commits....
[14:46]michelec2: nevermind, too late now. No big drama
[14:46]michelec2: will take a look at TDE/tdelibs#150 tomorrow and let you know
[14:46]tde-bot: [TGW][tdelibs] #150 - KSSL: Add Let's Encrypt certificates support
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/150
[14:54]Slávek: In any case, it seems as a good step forward.
[14:59]michelec2: yes, kweather with system icons is nice
[15:01]michelec2: regarding TDE/tdelibs#150, would that be a fix for bug 2785?
[15:01]tde-bot: [TGW][tdelibs] #150 - KSSL: Add Let's Encrypt certificates support
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/150
[15:01]tde-bot: [Bug 2785] Let's encrypt certificates does not work, DST Root CA X3 invalid (/etc/trinity/ksslcalist outdated?)
https://bugs.trinitydesktop.org/show_bug.cgi?id=2785
[15:02]Slávek: Yes, but partly. In bug 2785 there is proposed that the list is automatically updated according to certificates in the system, which will be a good final solution.
[15:02]tde-bot: [Bug 2785] Let's encrypt certificates does not work, DST Root CA X3 invalid (/etc/trinity/ksslcalist outdated?)
https://bugs.trinitydesktop.org/show_bug.cgi?id=2785
[15:03]michelec2: ah ok, thanks for the info
[15:03]Slávek: Therefore, TDE/tdelibs#150 is a good step forward, but there is still space for further improvements.
[15:04]tde-bot: [TGW][tdelibs] #150 - KSSL: Add Let's Encrypt certificates support
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/150
[15:04]michelec2: yes, understood. one step at a time :-)
[15:04]Slávek: (Y)
[15:05]michelec2: Regarding TDE/tdevelop#16, should we merge as is and deal with TDevelop Designer crashes separately? the PR code is pretty much the same as the TQt Designer PR, just one line is different
[15:05]Slávek: TDE-Bot, thank you for actively responding - we are happy to have you here :)
[15:05]tde-bot: [TGW][tdevelop] #16 - Designer: use global includes instead of includehints and remove duplicated include directives if found in UI files.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdevelop/pulls/16
[15:05]michelec2: love the bot (L)
[15:05]Slávek: During the test I watched two things:
[15:05]Slávek: 1. Crash during saving => not related to mentioned PR.
[15:06]michelec2: ok
[15:06]Slávek: 2. No includehints or includes were generated there in the UI file.
[15:06]Slávek: I do not know if it is a problem on my testing machine or whether it is right that there were no includes.
[15:07]michelec2: what did you put on the dialog/widget? includehints were only added for custom or plugin widgets
[15:07]Slávek: Line input, spin box, listbox,...
[15:07]michelec2: you can try to build the same dialog in TQt Designer and compare the ui file produced there. You can also send me the file and I can test here too
[15:08]Slávek: Maybe I have to insert some TDE widgets instead of TQt one.
[15:08]Slávek: In any case, code seems good.
[15:09]michelec2: @Line input, spin box, listbox: if there are TDE widgets there should be includehints without the PR and includes with PR. If they are TQT widget, not sure. I can test here
[15:10]michelec2: in TQt Designer I just created a form and put a TQt spin box and line edit --> no includes
[15:11]michelec2: same thing with TDE widget, includes are in the .ui file
[15:11]michelec2: TQt Designer support standard widgets (TQt) natively. Then you can have custom widgets or plugin widgets. TDE widgets are native
[15:12]michelec2: *are not native, are plugin
[15:22]Slávek: So it seems, that you can merge TDE/tdevelop#16
[15:22]tde-bot: [TGW][tdevelop] #16 - Designer: use global includes instead of includehints and remove duplicated include directives if found in UI files.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdevelop/pulls/16
[15:24]michelec2: (y)
[15:26]michelec2: done
[15:27]michelec2 has left

tde-devs@chat.jabb.im < 2022/01/26 >