tde-devs@chat.jabb.im < 2022/03/09 >
[10:24]Slávek has left
[11:19]Slávek has joined
[12:17]blu.256 has joined
[12:17]blu.256 has left
[13:17]blu.256 has joined
[14:17]blu.256 has left
[14:17]blu.256 has joined
[14:49]Slávek: Hi Philippe
[14:50]Slávek: For TDE/tdelibs#156 - I have the idea whether there could be useful to do a second variant of the KSVGIconEngine::load, which expects TQDomDocument instead of the file name.
[14:50]tde-bot: [TGW][tdelibs] #156 - SVG images support for TDEHTML
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/156
[14:52]Slávek: This could serve to avoid using a temporary file for SVG data.
[14:55]Slávek: Existing method KSVGIconEngine::load could be divided into two so that when using a variant with the file name, it loads the file into TQDomDocument and continued by calling the method that expects TQDomDocument.
[14:56]Slávek: What do you think about it?
[15:13]blu.256: It seems like a good idea, avoiding creating a temp file for this
[15:14]blu.256: I will certainly look into this possibility
[15:14]blu.256: Thank you
[15:15]blu.256 has left
[15:25]blu.256 has joined
[18:41]Slávek has left
[19:30]Slávek has joined
[21:47]Slávek: @blu.256, you can see notes for the first results of tests on my computer.
[22:39]blu.256: @Slávek: okay, thank you. looks like the PR needs some polishing.
[22:39]Slávek: Now I found fundamental problem...
[22:40]blu.256: I have left a comment on 0x0 size case.
[22:40]Slávek: ...comment will be soon in TGW.
[22:40]blu.256: Okay, but I'll probably read it later. It's a late hour here
[22:43]Slávek: comment is ready.
[22:45]blu.256: Okay
[22:45]Slávek: The comment applies to the first commit in PR because the current solution causes crash.
[22:46]Slávek: Method toPixel in helper is:
return m_engine->painter()->toPixel(s, hmode);
[22:46]Slávek: so without 'painter' it causes null pointer dereference.
[22:50]blu.256: okay, noted
[22:51]blu.256: I'm logging off for now
[22:51]Slávek: ok, good night to you
[22:51]blu.256: Good night (?) to you too
[22:52]blu.256 has left
[22:52]Slávek: Thank you. I'm a night owl - I'll be active for some time :)

tde-devs@chat.jabb.im < 2022/03/09 >