tde-devs@chat.jabb.im < 2022/05/11 > |
|---|
| [09:10] | Slávek has left |
| [10:24] | Slávek has joined |
| [15:19] | blu.256 has joined |
| [15:19] | Slávek: Hi Philippe! |
| [15:19] | Slávek: how about TDE/tdelibs#164? |
| [15:20] | tde-bot: [TGW][tdelibs] #164 - TDEFontDialog: Fix font style matching.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/164 |
| [15:21] | blu.256: I just created a related PR for a similar fix for KOffice |
| [15:21] | blu.256: (Hello, btw) |
| [15:22] | blu.256: It's temporary, but will solve the problem until R14.1.0, when hopefully KOffice switches to the systemwide TDEFontDialog |
| [15:22] | Slávek: Yes, I see it. |
| [15:22] | Slávek: I believe that commit's comment may not be "temporary for R14.0.x", because for now it's valid for all branches. |
| [15:23] | Slávek: Therefore, it can have a comment similar to commit in tdelibs. |
| [15:23] | blu.256: Like, "This resolves issue [issue]"? |
| [15:25] | blu.256: nvm |
| [15:25] | Slávek: Like: "TDEFontChooser_local: Fix font style matching.
This applies the same fix as in tdelibs for TDEFontDialog.
This resolves..." |
| [15:25] | blu.256: Oh, okay |
| [15:25] | blu.256: A little different from what I had in mind :) |
| [15:26] | Slávek: I want it to clearly declare what is fixed and based on what :) |
| [15:26] | blu.256: Message amended |
| [15:27] | Slávek: The fact that we want this "_local" class to remove in the near feature is not decisive for this moment. |
| [15:28] | blu.256: So, TDE/tdelibs#164 and TDE/koffice#24 are good for merging? |
| [15:28] | tde-bot: [TGW][koffice] #24 - Temporary font style fix
https://mirror.git.trinitydesktop.org/gitea/TDE/koffice/pulls/24 |
| [15:28] | tde-bot: [TGW][tdelibs] #164 - TDEFontDialog: Fix font style matching.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/164 |
| [15:29] | Slávek: Although I haven't done a test in koffice, I approved it right now. |
| [15:30] | blu.256: Ok, let me do a last test, just to be sure... |
| [15:31] | Slávek: (Y) |
| [16:59] | blu.256: Alright, merging both PRs |
| [17:00] | Slávek: (Y) |
| [17:04] | Slávek: tdelibs also backported? |
| [17:04] | Slávek: I see it right now :) (Y) |
| [17:09] | blu.256: Yes, issues TDE/tde#81 TDE/koffice#22 closed and milestones added. |
| [17:09] | tde-bot: [TGW][tde] #81 - Font variants issues
https://mirror.git.trinitydesktop.org/gitea/TDE/tde/issues/81 |
| [17:10] | Slávek: great, good work |
| [17:10] | Slávek: rebuilds for PSB and PTB will be started soon |
| [17:11] | blu.256: thank you :) |
| [17:17] | blu.256 has left |
| [18:51] | Slávek has left |
| [20:06] | Slávek has joined |
| [20:07] | Slávek has left |
| [20:08] | Slávek has joined |
tde-devs@chat.jabb.im < 2022/05/11 > |
|---|
