tde-devs@chat.jabb.im < 2022/05/20 >
[08:55]Slávek has left
[10:03]Slávek has joined
[10:35]Slávek has left
[11:09]blu.256 has joined
[12:09]blu.256 has left
[12:09]blu.256 has joined
[12:42]Slávek has joined
[13:43]michelec2 has joined
[13:50]Slávek: Philippe, TDE/tdelibs#168 looks great! This makes absolutely clear sense that indices have increased by one due to add the 'T' prefix.
[13:50]tde-bot: [TGW][tdelibs] #168 - dcopclient: Fix TQMap/TQValueList display
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/168
[13:51]michelec2: the PR is good but please look at my test comment. There may be something else to fix
[13:52]blu.256: @Michele yes, already working on it
[13:55]Slávek: In any case, it seems that we are on good way to solve it.
[13:58]michelec2: yes, and that would be a good improvement!
[14:01]blu.256: Error seems related to TQStringList type
[14:01]michelec2: quite possibly
[14:01]blu.256: That's what I can see from playing around with various dcop calls
[14:01]michelec2: because the white lines seems to corespond the the strings that should have been printed
[14:02]blu.256: Conversely QCStringLists and TQValueList<TQCString> types work correctly
[14:02]michelec2: (y)
[14:23]blu.256: Fix is ready and tested, give me a min to push it
[14:24]blu.256: Okay
[14:25]blu.256: Michele, you can test it now again if you'd like to
[14:31]Slávek has left
[14:32]blu.256 has left
[14:32]blu.256 has joined
[14:38]michelec2: ok thanks
[14:49]blu.256 has left
[14:52]blu.256 has joined
[14:53]blu.256 has left
[15:06]blu.256 has joined
[15:45]michelec2: @blu.256: TDE/tdelibs#168 looks great!
[15:45]tde-bot: [TGW][tdelibs] #168 - dcopclient: Fix TQMap/TQValueList display
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/168
[15:45]michelec2: please see my comment before backporting
[15:45]michelec2: best thing is to do a test on r14.0.x acutally
[15:48]blu.256: I have no R14.0.x installations handy :-(
[15:49]blu.256: but the changes aren't that radical if you look at the two commits
[15:49]michelec2: ok, then just double check the changes and if they look good go ahead and backport
[15:50]michelec2: I think the changes I made were returning a TStringList or TQVariant for some methods instead of whatever was there before
[15:50]michelec2: so the fixes in your PR may not relate to that
[15:50]blu.256: I'm looking at the commits history but don't see anything related to the file I modified
[15:50]blu.256: You mean this commit? https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/commit/352c8f6a2190a65107a30c42230b67018fc5625f
[15:51]blu.256: doesn't look like it would interfere
[15:51]michelec2: let me see
[15:51]michelec2: ah no, not that one
[15:51]michelec2: most likely changes in tdeio media manager...
[15:51]michelec2: let me see if I can find it
[15:56]blu.256: if it is in tdeio it should not interfere, I only modified the dcop console client
[15:57]michelec2: yes, they are in tdeio media manager
[15:57]michelec2: I added some functions that return TQStringVariantMap
[15:57]michelec2: so you fix should not be an issue at all
[15:57]blu.256: TQStringVariantMap? what is this?
[15:58]michelec2: it's a map that has string keys and return variant objects
[15:58]michelec2: heavily used in media manager dcop calls :-)
[15:58]blu.256: ok, but do those work with dcopclient or kdcop?
[15:58]michelec2: you can try mountByNode call. pass /dev/sdX (a valid partition on your system) to mount the disc
[15:59]michelec2: yes, work in kdcop
[15:59]blu.256: just checked, they don't work with dcopclient
[15:59]michelec2: I thought so, I was abut to test myself
[15:59]blu.256: shouldn't be too hard to add
[16:00]blu.256: maybe in separate PR so that it gets merged in master only?
[16:00]michelec2: by the way, when you test, try both a disc that can be mounted and one that cannot, because the return variant object is different in the two cases
[16:00]michelec2: variable number of element in the map
[16:01]michelec2: dcop client prints "<TQStringVariantMap>"
[16:01]michelec2: will be good to fix up this as well in a separate PR
[16:01]blu.256: meanwhile can I merge & backport TDE/tdelibs#168?
[16:02]tde-bot: [TGW][tdelibs] #168 - dcopclient: Fix TQMap/TQValueList display
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/168
[16:02]michelec2: yes, I already approved that
[16:02]blu.256: (Y)
[16:02]michelec2: I am going to sleep now. If you work on the TQStringVariantMap and create a PR, I will test it tomorrow
[16:03]michelec2: btw: https://mirror.git.trinitydesktop.org/cgit/tdelibs/commit/?id=2cc91245
[16:04]michelec2: this is where TQStringVariantMap was added. And I think this is not in r14.0.x
[16:04]blu.256: okay, good night
[16:06]michelec2: and yes, TQStringVariantMap is not in R14.0.x
[16:06]blu.256: Yes, it's not in r14.0.x
[16:06]michelec2: so no issue to backport TDE/tdelibs#168
[16:06]tde-bot: [TGW][tdelibs] #168 - dcopclient: Fix TQMap/TQValueList display
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/168
[16:07]michelec2: and if you fix up master for TQStringVariantMap, that PR will not need to be backported
[16:07]blu.256: done already, now to work on adding TQStringVariantMap support
[16:07]michelec2: (y)
[16:07]blu.256: understood :-)
[16:07]michelec2: have a good evening. and thanks for the good work!
[16:07]michelec2: see you
[16:07]blu.256: See you!
[16:07]michelec2 has left
[16:11]blu.256 has left
[16:26]blu.256 has joined
[16:26]blu.256 has left
[16:53]blu.256 has joined
[16:53]blu.256 has left
[17:27]blu.256 has joined
[17:27]blu.256 has left
[17:47]blu.256 has joined
[17:49]blu.256: I'm done with TQStringVariantMap, only I pushed the change directly to master because the change was trivial enough: https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/commit/8d0bae4092
[17:49]blu.256 has left
[18:44]Slávek has joined
[22:31]Slávek: Note: Builds of tdelibs with recent patches for PSB and PTB are underway.

tde-devs@chat.jabb.im < 2022/05/20 >