#trinity-desktop < 2026/05/19
[00:16]agneli has quit (Ping timeout: 252 seconds)
[00:57]ceux: am i to be using KDesktops Display controls or TDERandrTray or
[01:00]magnus_6 has joined
[01:01]magnus_6 has quit (Changing host)
[01:01]magnus_6 has joined
[01:13]agneli has joined
[01:55]magnus_6 has quit (Ping timeout: 244 seconds)
[02:00]ceux: i dont really udnerstand how to do a PR in gitea
[02:45]Fat-Zer: ceux: have you seen this: https://wiki.trinitydesktop.org/TDE_Gitea_Workspace#ContributeCode
[02:46]Fat-Zer: though if you just created the account first you'll probably have to be added to the TDE/Contributor group by SlavekB of MichaelC
[02:47]Fat-Zer: alternatively it should be possible to create a PR via AGit workflow, but I haven't tested if it does actually work
[02:48]Fat-Zer: https://docs.gitea.com/usage/agit
[02:48]tde-bot: Page title: AGit | Gitea Documentation
[05:15]Fat-Zer has quit (Ping timeout: 276 seconds)
[05:27]Fat-Zer has joined
[06:19]pitriss has quit (Ping timeout: 272 seconds)
[09:35]SlavekB has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org)
[10:21]SlavekB has joined
[12:51]pitriss has joined
[14:05]ceux: Fat-Zer: I did see that yes...
[14:05]ceux: Fat-Zer: helpful, i was able to make a PR on tdebase - though i dont know if anyone reviews it.
[14:07]ceux: or how to get it 'reviewed', do I just assign it or
[14:12]SlavekB: Ceux, I've added you as a member of the Contributors team, so you can now PR in the branch as described on the TDE Wiki.
[14:13]SlavekB: When the PR is ready, you can request revisions by the Core and Owners teams there.
[14:24]ceux: so I think I did it correctly
[14:25]ceux: SlavekB: here it is https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/pulls/739 but i think i did not need to be a contrib to create the PR
[14:26]ceux: i created it against the master branch on "TDE:tdebase" from "ceux:tdebase" on a feature branch I made.
[14:26]ceux: by "request revisions" how do Ido that, assign a 'assignee?'
[14:27]SlavekB: It looks good, except that we prefer a collaboration model over shared branches instead of forks - as mentioned in the TDE Wiki.
[14:28]ceux: what does this mean, i commit to... TDE directly?
[14:28]ceux: i don't use github to much the whole PR thing is a little different for me
[14:28]SlavekB: Exactly. By being a member of the Contributors team, you can push the branch directly to TDE/tdebase instead of co ceux/tdebase.
[14:31]ceux: so i would create a feat/xyz on tdebase
[14:31]ceux: OK so i can add a remote here for the TDE/tdebase and push to it
[14:31]ceux: SlavekB: in regarding asking for a review, what is appropritae
[14:32]SlavekB: request revisions and select Core team and Owners team.
[14:36]ceux: I don't see it. Sorry
[14:37]SlavekB: When selecting to request a revision, it is advantageous to use search.
[14:37]ceux: no, I dnt see how to request a revision
[14:39]SlavekB: https://wiki.trinitydesktop.org/TDE_Gitea_Workspace#To_ask_for_and_review_PRs_from_other_contributors
[14:39]tde-bot: Page title: TDE Gitea Workspace - Trinity Desktop Project Wiki
[14:51]ceux: so should i assign it directly to you or
[14:52]ceux: OK i was able to do that

#trinity-desktop < 2026/05/19