#tde-devs < 2023/05/30 >
[09:12]SlavekB has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org)
[10:14]SlavekB has joined
[16:51]denk: SlavekB: please review https://mirror.git.trinitydesktop.org/gitea/TDE/tde-cmake/pulls/91
[16:52]SlavekB: Why a platform-dependent change?
[16:53]denk: it's easy way, as I guess
[16:53]SlavekB: The previous code was looking for linker help to report the option "-pie" and if so, it was used.
[16:54]SlavekB: This looked like a clear way independent of plaform.
[16:54]denk: illumos ld tried to add -z type=pie instead of -pie
[16:55]denk: not sure about oracle solaris
[16:55]SlavekB: Did you look at the code I pushed there? Did you test it?
[16:56]SlavekB: https://mirror.git.trinitydesktop.org/gitea/TDE/tde-cmake/commit/2b8ef3e8765428e4ec3b7bb8abf06c15378079aa
[16:56]tde-bot: Page title: tde_setup_architecture_flags: Add linker -pie flag test for CMake < 3.18. ยท 2b8ef3e876 - tde-cmake - TDE Gitea Workspace
[16:57]denk: yes, I just built tdegames with the changes
[16:59]SlavekB: Is there anything non-functional on such a code?
[17:00]denk: not sure, let me to retest the pure matching again
[17:00]SlavekB: For me it seems a clearer than searching for a specific platform and a specific variant.
[17:02]denk: matches -pie and -ztype=pie?
[17:11]denk: SlavekB: https://paste.dilos.org/?5ff7f20e84e3322d#yJ20g2zed9J0/MI0DZ3uJU4lCPqOe5mhco1oQ2v6UyY=
[17:11]denk: better?
[17:12]denk: [-z type=type] specify the type of object (exec, kmod, reloc, shared)
[17:12]denk: our ld
[17:12]denk: it also should have "shared, pie"
[17:15]SlavekB: If the option is mentioned as "-z type=pie", use "-pie" probably won't work?
[17:15]denk: yep
[17:18]SlavekB: At the same time, it probably will also fail to detect when using the check_linker_flag?
[17:19]SlavekB: ...so there will be another change?
[17:20]denk: probably, yes, I need to test check_linker_flag branch
[17:22]denk: -- Performing Test LINKER_PIE_SUPPORT
[17:22]denk: -- Performing Test LINKER_PIE_SUPPORT - Failed
[17:22]denk: nice, it works
[17:22]denk: will commit the changes
[17:22]SlavekB: no, if can be used "-z type=pie"
[17:26]denk: indeed...
[17:31]denk: SlavekB: https://paste.dilos.org/?6bcfc2abec4ec33f#VisYXuzNNib/zE0k9un4dXJz3Jg6bbsswyjDMnrNTYA=
[17:31]denk: quick review
[17:33]denk: line 22 fixed
[17:39]SlavekB: The code has become a little more complicated, but it should work.
[17:40]denk: pushed
[17:42]SlavekB: Note: for include( CheckLinkerFlag ) need to be used with OPTIONAL
[17:45]SlavekB has quit (Quit: TDE Kopete : https://trinitydesktop.org)
[23:06]blu256 has joined
[23:08]blu256 has quit (Client Quit)
[23:37]SlavekB has joined

#tde-devs < 2023/05/30 >