#tde-devs < 2023/06/01 >
[08:06]micheleC has joined
[08:06]micheleC: @denk not sure you saw comment on TDE/tqt3#72
[08:06]tde-bot: [TGW][tqt3] #72 - Drop fallback recursive mutex implementation
[08:06]tde-bot: https://mirror.git.trinitydesktop.org/gitea/TDE/tqt3/pulls/72
[08:07]micheleC: would you be able to do a test to make sure the PR works well also on DilOs/Solaris/IllumOs (or whatever the system you are using is :-) )?
[08:44]SlavekB has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org)
[09:36]denk: I was busy, just a moment...
[09:36]SlavekB has joined
[09:39]denk: micheleC: it should work, but need a test
[09:40]denk: I can test it in a few time
[10:40]micheleC: @denk thanks, appreciated the help
[11:16]denk: building process is started
[11:16]micheleC: (y)
[11:30]denk: the packages built
[11:30]denk: would you like I test it?
[11:30]denk: it looks ok and, probably, it should work
[13:15]micheleC: yes please, if you could do a test it would be great
[13:16]micheleC: you can look at bug 2526 as per my comment on that PR for an easy way to test
[13:16]tde-bot: [Bug 2526] [FreeBSD] Konqueror freezes upon typing '/' in address bar
[13:16]tde-bot: https://bugs.trinitydesktop.org/show_bug.cgi?id=2526
[13:40]denk: ok
[13:44]denk: micheleC: I can't reproduce the bug (without the patch)
[13:46]denk: probably, the result will be the same with the patch
[13:48]denk: https://postimg.cc/xcwZYbzF
[13:48]tde-bot: Page title: konq — Postimages
[13:49]denk: in a test non-global zone
[13:49]SlavekB: Without patch you probably need to remove "&& !defined(Q_OS_SOLARIS)" in src/tools/qmutex_unix.cpp
[13:51]SlavekB: In any case, problem from bug 2526 is already fixed by TDE/tqt3#68
[13:51]tde-bot: [TGW][tqt3] #68 - Fix level when using pthreads recursive mutex
[13:51]tde-bot: https://mirror.git.trinitydesktop.org/gitea/TDE/tqt3/pulls/68
[13:51]tde-bot: [Bug 2526] [FreeBSD] Konqueror freezes upon typing '/' in address bar
[13:51]tde-bot: https://bugs.trinitydesktop.org/show_bug.cgi?id=2526
[13:53]SlavekB: Condition "&& !defined(Q_OS_SOLARIS)" probably ensured that on SunOS-based systems recursive mutexes were not used at all.
[13:53]denk: ok, let me to remove it to test
[13:55]SlavekB: With TDE/tqt3#72, recursive mutexes will be used => here it is necessary to check whether the use of recursive mutexes will bring some new problem on SunOS-based systems.
[13:55]tde-bot: [TGW][tqt3] #72 - Drop fallback recursive mutex implementation
[13:55]tde-bot: https://mirror.git.trinitydesktop.org/gitea/TDE/tqt3/pulls/72
[13:56]micheleC: be aware that if you remove "&& !defined(Q_OS_SOLARIS)" and do a full reboot, tdm will lock up
[13:56]micheleC: actually all I need is to see that even with the patch, no problem happens
[13:57]SlavekB: If TDE/tqt3#68 is already applied, there should not be a problem.
[13:57]tde-bot: [TGW][tqt3] #68 - Fix level when using pthreads recursive mutex
[13:57]tde-bot: https://mirror.git.trinitydesktop.org/gitea/TDE/tqt3/pulls/68
[13:57]micheleC: the patch already remove "&& !defined(Q_OS_SOLARIS)" and use recursive pthread mutexes, so it everything works fine with the patch, that's it
[13:58]micheleC: @Slavek: ah yes, you are right. no lock up then :-)
[13:59]denk: step 1: building tqt without Q_OS_SOLARIS
[14:01]micheleC: @denk: no need actually. if TDE/tqt3#68 is already applied, you will not see the problem anyway. All is needed is to test with PR#72 and make sure you don't see any problems, since with PR#72 recursive mutexes would be used in Solaris
[14:01]tde-bot: [TGW][tqt3] #68 - Fix level when using pthreads recursive mutex
[14:01]tde-bot: https://mirror.git.trinitydesktop.org/gitea/TDE/tqt3/pulls/68
[14:02]micheleC: maybe we wrote too many comments and we confused you a bit :-)
[14:05]denk: still works
[14:06]micheleC: with PR#72 you mean, right?
[14:07]denk: I mean I removed && !defined(Q_OS_SOLARIS) from qmutex_unix.cpp
[14:07]denk: and it works
[14:07]micheleC: ah, sure. That would work because PR #68 fixed the issue in that case.
[14:07]micheleC: what I need now is to test that applying PR #72 does not create any new problem
[14:07]denk: ok, let me to test the latest patch
[14:07]micheleC: thanks
[14:09]denk: take commit 568339edf78597c0294b25bcf0259b35c5ceebbf (HEAD -> drop/fallback-recursive-mutex, origin/drop/fallback-recursive-mutex) to test...
[14:09]tde-bot: Commit History
[14:09]tde-bot: https://www.trinitydesktop.org/patches/
[14:11]denk: still works
[14:11]denk: unbreakable sunos :)
[14:12]denk: and yes, I rebooted the zone
[14:13]micheleC: great, thanks a lot for taking the time to test
[14:13]denk: not at all
[14:13]micheleC: (y)
[14:14]denk: ok, now I will use the patch in the target packages for dilos
[14:15]micheleC: ok
[15:50]micheleC has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org)
[18:07]denk: tdeedu built, it needs some sunos patches
[18:14]denk: SlavekB: https://paste.dilos.org/?cb6be12b772e2656#LkXHPAUcm3IaGbwSUjsV7HQqBFGTviBrd0OQqs0p7xw=
[18:14]denk: with patched TDEMacros
[18:14]denk: fix/CMP0057_for_CheckLinkerFlag
[18:18]SlavekB: Oh, I understand, I will make a modification so that these policy is set only temporarily inside TDEMacros.
[18:19]SlavekB: However, now I have to go away, so I'll be offline for some time.
[18:20]denk: tdeedu built
[18:20]denk: there are no other issues
[18:20]denk: warnings only
[18:26]SlavekB has quit (Quit: Kopete : https://trinitydesktop.org)

#tde-devs < 2023/06/01 >