#tde-devs < 2023/06/20 > |
[06:49] | denk: hello guys, I have no access to the git repo to do anything |
[06:50] | denk: huh, works again, let's try to sqaush it... |
[06:55] | denk: micheleC: check it please |
[08:09] | micheleC: the squash itself is good, but the commit message is a bit of a mess. You should have use "fix" instead of "squash" in the editor, this would have kept only the first message |
[08:10] | micheleC: you can edit the commit message again with "git commit --amend" and force push it again |
[08:11] | micheleC: "Find power related system tools instead of hardcode them. |
[08:11] | micheleC: Signed-off-by: Denis Kozadaev <denis@dilos.org>" |
[08:11] | micheleC: or something like that |
[08:18] | denk: check it once again |
[08:19] | micheleC: Looks good. I will merge it |
[08:20] | micheleC: looks like you got rebasing and squashing in your toolbox now :-) |
[08:21] | micheleC: @SlavekB: I assume it is ok to backport TDE/tdebase#359 to R14.1.1, right? |
[08:21] | tde-bot: [TGW][tdebase] #359 - find-poweroff-halt-reboot |
[08:21] | tde-bot: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/pulls/359 |
[08:22] | SlavekB: yes, it seems ok to backport |
[08:22] | micheleC: (y) |
[09:21] | SlavekB has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org) |
[10:29] | SlavekB has joined |
[14:01] | micheleC has left (Kopete 0.12.7 : http://trinitydesktop.org) |
[17:15] | SlavekB has quit (Quit: TDE Kopete : https://trinitydesktop.org) |
[22:27] | SlavekB has joined |
#tde-devs < 2023/06/20 > |
© 2010-2024 Trinity Desktop Project