#tde-devs < 2025/03/14 >
[00:35]micheleC has joined
[06:24]micheleC: @denk: what is a better name for your new game? tdeknighttour or tdeknightmove?
[06:26]micheleC: also not sure against which tqt3 version you have built it. It FTBFS with:
[06:26]micheleC: /home/tde_src/2_build/build/applications/games/tdeknightmove/src/mainwindow.cpp:25:45: error: ‘SLOT’ was not declared in this scope; did you mean ‘TQ_SLOT’?
[06:26]micheleC: 25 | actionQuit = KStdAction::quit(this, SLOT(close()), 0);
[06:26]micheleC: | ^~~~
[06:26]micheleC: | TQ_SLOT
[06:27]micheleC: SLOT is long gone in tqt3, you need to use TQ_SLOT
[06:27]micheleC: if possible, check against latest master code and update your code
[07:57]denk: my system does not compile TQ_SLOT
[07:58]micheleC: what version of tqt3 do you have?
[07:58]denk: micheleC: original name is "Knight's tour" (from the wiki)
[07:58]micheleC: as in r14.1.n? r14.0.n?
[07:59]denk: tqt3-14.1.1 Multiplatform C++ application framework
[07:59]micheleC: so should we call it tdeknighttour instead of tdeknightmove?
[07:59]denk: yeah, tdeknighttour is good
[07:59]micheleC: (y)
[07:59]micheleC: I can fix up the code to build on top of master and r14.1.x if you want
[08:01]micheleC: I have renamed the repo to tdeknighttour
[08:04]denk: please fix it
[08:05]micheleC: will do
[08:05]denk: does tqt have a macro for SLOT/TQ_SLOT?
[08:05]denk: maybe by version...
[08:06]denk: or add a macro for backward compatibility
[08:07]micheleC: new version have TQ_SIGNAL and TQ_SLOT
[08:07]micheleC: SIGNAL and SLOT are no longer supported
[08:09]denk: ntqobjectdefs.h:128:#ifdef SLOT
[08:09]denk: ntqobjectdefs.h:129:#undef SLOT
[08:09]denk: ntqobjectdefs.h:137:#define SLOT(a) "1""a"
[08:09]denk: ntqobjectdefs.h:141:#define SLOT(a) "1"#a
[08:09]denk: grep from the files
[08:10]micheleC: yes, you have old tqt3 version. It has changed since then
[08:10]denk: I understood you, thanks
[08:11]micheleC: I have create a PR with the fixes in your repo
[08:11]denk: does the code have some other bugs?
[08:11]micheleC: could you please merge it when you have time?
[08:11]micheleC: no, only slot and signal. After that I was able to build it and install it
[08:11]denk: micheleC: you could it do too
[08:12]micheleC: yes, I could. But we like to follow a clean process if possible. And since you are still the owner of the repo for now....
[08:12]denk: you wanted to move the repo from my account (as I expected)
[08:12]micheleC: yes, we will move soon, after I prepare packaging files for Debian
[08:13]micheleC: if you prefer, I will merge the PR myself, not a big deal anyway
[08:13]denk: merged
[08:13]denk: check it
[08:14]micheleC: nice, thanks
[08:15]denk: thank you that you accept it instead of reject :)
[08:18]micheleC: it's a little toy, but why reject it? :-)
[08:20]denk: to avoid supporting another code
[08:20]denk: admins/developers are too lazy to do it
[08:23]micheleC: no worries
[08:33]micheleC: there will be some more fixes for cmake code, I will create another PR soon
[08:38]denk: just ping me and I will merge it
[08:43]micheleC: (y)
[09:13]micheleC: PR for cmake files is ready
[09:23]denk: merged
[09:26]micheleC: thx
[09:27]denk: btw, maybe README.md replace by README
[09:31]denk: I did it, README renamed to README.md
[09:32]micheleC: yes, README.md will need some updates once we create the component on TWTW for translations
[09:33]denk: now update it as it should look like
[09:57]denk: merging can be continued in a hour, it's time to eat somebody on the lunch...
[12:01]micheleC: (y)
[12:05]micheleC: @denk: I will probably move the repo during the weekend, tonight I don't the required time for it
[12:05]micheleC: *don't have
[12:10]denk: of course
[14:47]micheleC has left (Kopete 0.12.7 : http://trinitydesktop.org)
[16:25]SlavekB has quit (Quit: Kopete 0.12.7 : http://trinitydesktop.org)

#tde-devs < 2025/03/14 >